BewareMyPower commented on code in PR #24523:
URL: https://github.com/apache/pulsar/pull/24523#discussion_r2234347095
##########
pulsar-broker/src/main/java/org/apache/pulsar/compaction/TopicCompactionService.java:
##########
@@ -67,14 +60,27 @@ public interface TopicCompactionService extends
AutoCloseable {
* @param publishTime the publish time of entry.
* @return the first entry metadata that greater or equal to target
publishTime, this entry can be null.
*/
- CompletableFuture<Entry> findEntryByPublishTime(long publishTime);
+ CompletableFuture<Position> findEntryByPublishTime(long publishTime);
Review Comment:
See https://github.com/apache/pulsar/blob/master/pip/pip-429.md#public-api
> Change the return value of findEntryByPublishTime from
CompletableFuture<Entry> to CompletableFuture<Position>. This change is made
because the caller only needs the position of the last message, not the entire
entry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
