lhotari opened a new pull request, #24529:
URL: https://github.com/apache/pulsar/pull/24529

   ### Motivation
   
   The configuration code added in #16165 intends to set the default value of 
connectionMaxIdleSeconds in Pulsar Proxy to -1. This is not the case. The 
effective value is 60 since the value is set after the object is no longer used.
   
   
https://github.com/apache/pulsar/blob/08caff42b71e619b66094df6b3bcaeb1eba1e97a/pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConnection.java#L745-L746
   
   full method code:
   
   
https://github.com/apache/pulsar/blob/08caff42b71e619b66094df6b3bcaeb1eba1e97a/pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConnection.java#L732-L767
   
   ### Modifications
   
   - move the line of code a few lines earlier so that it gets used
   - add a test
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update 
later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to