codelipenghui commented on code in PR #24424:
URL: https://github.com/apache/pulsar/pull/24424#discussion_r2154567415
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentReplicator.java:
##########
@@ -176,7 +180,13 @@ private static final class ProducerSendCallback implements
SendCallback {
@Override
public void sendComplete(Throwable exception, OpSendMsgStats
opSendMsgStats) {
if (exception != null) {
- log.error("[{}] Error producing on remote broker",
replicator.replicatorId, exception);
+ Throwable actEx =
FutureUtil.unwrapCompletionException(exception);
+ if (actEx instanceof
PulsarClientException.ProducerQueueIsFullError) {
+ log.error("[{}] Discard to replicate non-persistent
messages to the remote cluster because the"
Review Comment:
warning should be fine since there is no at-least-once sematics for
non-partitioned topic geo-replication.
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentReplicator.java:
##########
@@ -176,7 +180,13 @@ private static final class ProducerSendCallback implements
SendCallback {
@Override
public void sendComplete(Throwable exception, OpSendMsgStats
opSendMsgStats) {
if (exception != null) {
- log.error("[{}] Error producing on remote broker",
replicator.replicatorId, exception);
+ Throwable actEx =
FutureUtil.unwrapCompletionException(exception);
+ if (actEx instanceof
PulsarClientException.ProducerQueueIsFullError) {
+ log.error("[{}] Discard to replicate non-persistent
messages to the remote cluster because the"
Review Comment:
```suggestion
log.warn("[{}] Discard to replicate non-persistent
messages to the remote cluster because the"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
