dao-jun commented on PR #24423:
URL: https://github.com/apache/pulsar/pull/24423#issuecomment-2983739402

   > > The root cause is similar with 
[apache/bookkeeper#4556](https://github.com/apache/bookkeeper/pull/4556). I 
think maybe we can consider close the channel if it has too many pending buffer 
to write.
   > 
   > I don't think that there's a need to close the channel. For Pulsar 
brokers, the memory is already more or less bounded with 
`maxMessagePublishBufferSizeInMB`, `managedLedgerMaxReadsInFlightSizeInMB` and 
`managedLedgerCacheSizeMB` settings. The only major gap seems to be the 
GET_TOPICS_OF_NAMESPACE/GET_TOPICS_OF_NAMESPACE_RESPONSE and 
WATCH_TOPIC_LIST/WATCH_TOPIC_LIST_SUCCESS & WATCH_TOPIC_UPDATE handling.
   
   Yes, but maybe we should call `cnx.completedSendOperation` after response 
send finished.
   like here 
   
![image](https://github.com/user-attachments/assets/9bcbe3f8-36e9-4777-bafc-69c28d14b926)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to