poorbarcode commented on code in PR #19783:
URL: https://github.com/apache/pulsar/pull/19783#discussion_r2104318455
##########
tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/BlobStoreBackedReadHandleImpl.java:
##########
@@ -120,6 +123,7 @@ public CompletableFuture<LedgerEntries> readAsync(long
firstEntry, long lastEntr
}
CompletableFuture<LedgerEntries> promise = new CompletableFuture<>();
executor.execute(() -> {
+ touch();
Review Comment:
> I'm not claiming that the scenario that you are presenting couldn't
happen. It's just that it's something that is not likely to happen.
Since it may happen, should we use a read-write lock to protect it? Or add a
special log to let us know the issue happened, which is different from other
scenarios?
> I have answered.
https://github.com/apache/pulsar/pull/19783#discussion_r2100437635 . That means
"no".
And if the value of
`managedLedgerInactiveOffloadedLedgerEvictionTimeSeconds` is small enough, the
probability of the issue occurring goes up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
