liangyepianzhou commented on PR #24293: URL: https://github.com/apache/pulsar/pull/24293#issuecomment-2876060898
> Why don't other methods add the Async suffix but just `checkTopicExists`? For example: `checkNonPartitionedTopicExists` @AuroraTwinkle While reviewing https://github.com/apache/pulsar/pull/24225, I noticed an issue where a new method `checkTopicExistsAsync` was added but merely wraps `checkTopicExists`. This implementation approach confused me, and since the PR author had no intention of fixing this together, I went ahead and resolved it. If you'd like, you could check if there are other similar asynchronous-to-synchronous wraps in Pulsar and fix them. If you don't have time, I can take some time next week to do a deeper inspection of the Pulsar codebase and fix similar patterns. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
