Copilot commented on code in PR #2656: URL: https://github.com/apache/plc4x/pull/2656#discussion_r3655768567
########## .github/workflows/dotnet-platform.yml: ########## @@ -0,0 +1,120 @@ +# ---------------------------------------------------------------------------- +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# https://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# ---------------------------------------------------------------------------- +name: ".Net Platform Compatibility" + +on: + push: + branches: [ "develop", "plc4net" ] + paths: + - code-generation/** + - protocols/** + - plc4net** + pull_request: + branches: [ "develop", "plc4net" ] + paths: + - code-generation/** + - protocols/** + - plc4net** Review Comment: The path filter `plc4net**` is likely not matching the intended directory tree (usually `plc4net/**`). If this glob doesn’t match as expected, CI may not run on PLC4Net-only changes. ########## .github/workflows/dotnet-platform.yml: ########## @@ -0,0 +1,120 @@ +# ---------------------------------------------------------------------------- +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# https://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# ---------------------------------------------------------------------------- +name: ".Net Platform Compatibility" + +on: + push: + branches: [ "develop", "plc4net" ] + paths: + - code-generation/** + - protocols/** + - plc4net** + pull_request: + branches: [ "develop", "plc4net" ] + paths: + - code-generation/** + - protocols/** + - plc4net** + workflow_dispatch: + inputs: + forceUpdates: + description: "Forces a snapshot update" + required: false + default: 'false' + +permissions: + contents: read + +env: + DEVELOCITY_ACCESS_KEY: ${{ secrets.DEVELOCITY_ACCESS_KEY }} + +jobs: + test: + strategy: + matrix: + os: [ ubuntu-latest, macos-latest, windows-latest ] + fail-fast: false + runs-on: ${{ matrix.os }} + steps: + - uses: actions/checkout@v7 + + - name: Setup .Net + uses: actions/setup-dotnet@v5 + with: + dotnet-version: '8.0.x' + + - name: Setup Java + uses: actions/setup-java@v5 + with: + distribution: 'adopt' + java-package: jdk + java-version: 21 Review Comment: The `actions/setup-java` `distribution: 'adopt'` value has been deprecated/removed in typical GitHub hosted runner setups, and can cause the workflow to fail to install Java. Prefer a currently supported distribution such as `temurin` (or whichever the repo standardizes on). ########## plc4net/plc4net.sln: ########## @@ -1,24 +1,5 @@ -Microsoft Visual Studio Solution File, Format Version 12.00 - -# -# Licensed to the Apache Software Foundation (ASF) under one -# or more contributor license agreements. See the NOTICE file -# distributed with this work for additional information -# regarding copyright ownership. The ASF licenses this file -# to you under the Apache License, Version 2.0 (the -# "License"); you may not use this file except in compliance -# with the License. You may obtain a copy of the License at -# -# https://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, -# software distributed under the License is distributed on an -# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -# KIND, either express or implied. See the License for the -# specific language governing permissions and limitations -# under the License. -# - + +Microsoft Visual Studio Solution File, Format Version 12.00 Review Comment: The solution file now appears to start with an empty first line (containing only a BOM), pushing the required `Microsoft Visual Studio Solution File...` marker to line 2. Visual Studio/MSBuild tooling is sensitive to the marker being on the first line; this may make the `.sln` unreadable. Ensure the BOM (if present) is on the same line as the marker and remove any leading blank line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
