bziobrowski commented on code in PR #14664:
URL: https://github.com/apache/pinot/pull/14664#discussion_r1890464726
##########
pinot-query-planner/src/test/resources/queries/GroupByPlans.json:
##########
@@ -249,6 +249,39 @@
"\n LogicalTableScan(table=[[default, a]])",
"\n"
]
+ },
Review Comment:
Is this PR meant to enable trimming within (minSegmentTrim) and across
segments (minServerTrim) ?
If so - It'd be good to mention that :
- the former is disabled by default and requires using query option (or
cluster setting)
- the latter is enabled by default but probably haven't been applied so far
Apart from manual hinting I think we could propagate limit and order by
details to leaf plans and enable both types of trimming if:
- order by is based on group by key(s) only (not aggregates)
- there is no HAVING clause
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
