9aman commented on code in PR #14460:
URL: https://github.com/apache/pinot/pull/14460#discussion_r1843178346
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/SegmentCompletionManager.java:
##########
@@ -1015,7 +1076,12 @@ private SegmentCompletionProtocol.Response
processConsumedAfterCommitStart(Strin
// Common case: A different instance is reporting.
if (offset.compareTo(_winningOffset) == 0) {
// Wait until winner has posted the segment before asking this
server to KEEP the segment.
- response = hold(instanceId, offset);
+ // Keep if it's pauseless enabled
Review Comment:
We allow the replicas to build the segment. This ensures that:
1. `Reduced need for disaster recovery`: The server is persisted to disk on
atleast one of the servers.
2. `Continued ingestion on replicas`: The replicas can continue ingesting
newly created segments rather than waiting for the committing server to
complete the commit (existing behavior).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
