ankitsultana commented on code in PR #14198:
URL: https://github.com/apache/pinot/pull/14198#discussion_r1811507869
##########
pinot-query-planner/src/test/resources/queries/JoinPlans.json:
##########
@@ -294,19 +294,21 @@
"\n LogicalFilter(condition=[=($0,
_UTF-8'foo')])",
"\n
LogicalTableScan(table=[[default, b]])",
"\n PinotLogicalExchange(distribution=[hash[0]])",
- "\n PinotLogicalAggregate(group=[{0}],
agg#0=[MIN($1)])",
- "\n PinotLogicalExchange(distribution=[hash[0]])",
- "\n PinotLogicalAggregate(group=[{0}],
agg#0=[MIN($1)])",
- "\n LogicalProject(col3=[$2], $f1=[true])",
- "\n LogicalFilter(condition=[=($0,
_UTF-8'bar')])",
- "\n LogicalTableScan(table=[[default, b]])",
+ "\n LogicalProject(col3=[$0], $f1=[$1])",
Review Comment:
Interesting, I think this project is redundant? Something to note regardless
as we work on a proper long term solution. Same in the other parts of this plan.
##########
pinot-query-planner/src/test/resources/queries/WindowFunctionPlans.json:
##########
@@ -3404,7 +3404,7 @@
"sql": "EXPLAIN PLAN FOR WITH windowfunc AS (SELECT a.col1,
ROW_NUMBER() OVER(PARTITION BY a.col2 ORDER BY a.col3) as rownum from a) SELECT
a.col1, a.rownum FROM windowfunc AS a where a.rownum < 5",
"output": [
"Execution Plan",
- "\nLogicalProject(col1=[$0], $1=[$3])",
+ "\nLogicalProject(col1=[$0], w0$o0=[$3])",
Review Comment:
@shauryachats : can we also verify that this window query works after this
change? (as in it runs successfully)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
