soumitra-st commented on code in PR #13645:
URL: https://github.com/apache/pinot/pull/13645#discussion_r1807168639
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/DispatchClient.java:
##########
@@ -41,7 +45,17 @@ class DispatchClient {
private final PinotQueryWorkerGrpc.PinotQueryWorkerStub _dispatchStub;
public DispatchClient(String host, int port) {
- _channel = ManagedChannelBuilder.forAddress(host,
port).usePlaintext().build();
+ this(host, port, new GrpcConfig(Collections.emptyMap()));
+ }
+
+ public DispatchClient(String host, int port, GrpcConfig grpcConfig) {
Review Comment:
This constructor is only used in the other constructor to create non-tls
DispatchClient. Does it mean that if gRPC TLS is enabled on the server side,
then DispatchClient will always fail? I don't see a place where TLS enabled
DispatchClient is created. cc: @gortiz @Jackie-Jiang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
