Jackie-Jiang commented on code in PR #14199:
URL: https://github.com/apache/pinot/pull/14199#discussion_r1799977600
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##########
@@ -485,6 +485,16 @@ protected BrokerResponse handleRequest(long requestId,
String query, SqlNodeAndO
if (realtimeTableName == null) {
realtimeTableConfig = null;
}
+
+ if ((realtimeTableConfig != null && _routingManager.getDisabledTables()
Review Comment:
We should allow one table being disabled when querying both offline and
real-time table.
##########
pinot-broker/src/main/java/org/apache/pinot/broker/routing/BrokerRoutingManager.java:
##########
@@ -115,6 +115,7 @@ public class BrokerRoutingManager implements
RoutingManager, ClusterChangeHandle
private ZkHelixPropertyStore<ZNRecord> _propertyStore;
private Set<String> _routableServers;
+ private Set<String> _disabledTables = new HashSet<>();
Review Comment:
This is not thread safe. I think an easier way to handle this is to add
`_disabled` field into `RoutingEntry`, and update its value in
`onAssignmentChange()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
