gortiz commented on code in PR #14210:
URL: https://github.com/apache/pinot/pull/14210#discussion_r1796787011
##########
pinot-controller/pom.xml:
##########
@@ -121,13 +122,13 @@
</configuration>
</execution>
<execution>
- <id>npm ci</id>
+ <id>npm ci</id><!-- npm ci removes node_modules! -->
Review Comment:
IIRC npm install actually modifies `package.json` in order to install new
versions of the libraries, which is something we don't want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
