gortiz commented on code in PR #13943:
URL: https://github.com/apache/pinot/pull/13943#discussion_r1792150017


##########
pinot-query-planner/pom.xml:
##########
@@ -49,6 +49,11 @@
       <groupId>org.codehaus.janino</groupId>
       <artifactId>commons-compiler</artifactId>
     </dependency>
+    <dependency>
+      <groupId>org.immutables</groupId>
+      <artifactId>value</artifactId>

Review Comment:
   I've opened a PR using annotation processors in 
https://github.com/apache/pinot/pull/14185. If we merge that PR before this one 
we can modify this pom to use that mode as well, which will simplify this 
declaration.



##########
pinot-query-planner/pom.xml:
##########
@@ -49,6 +49,11 @@
       <groupId>org.codehaus.janino</groupId>
       <artifactId>commons-compiler</artifactId>
     </dependency>
+    <dependency>
+      <groupId>org.immutables</groupId>
+      <artifactId>value</artifactId>

Review Comment:
   I've opened a PR using annotation processors in 
https://github.com/apache/pinot/pull/14185. If we merge that PR before this one 
we can modify this pom to use that mode as well, which would simplify this 
declaration.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to