gortiz commented on code in PR #13930:
URL: https://github.com/apache/pinot/pull/13930#discussion_r1753575891
##########
pinot-spi/pom.xml:
##########
@@ -36,6 +36,82 @@
<build>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <version>3.7.1</version>
+ <executions>
+ <execution>
+ <id>copy-pinot-plugins</id>
+ <!-- The org.apache.pinot.spi.plugin.PluginManagerTest has tests
that requires plugin jars.
+ These jars could have been added to
src/test/resources/plugins, but that would increase the size of
+ source repository a lot. Instead, let Maven download these
jars and put them at the expected location.
+ -->
+ <phase>generate-test-resources</phase>
+ <goals>
+ <goal>copy</goal>
+ </goals>
+ <configuration>
+ <artifactItems>
+ <artifactItem>
+ <groupId>org.apache.pinot</groupId>
+ <artifactId>pinot-dropwizard</artifactId>
+ <version>0.10.0</version>
Review Comment:
> Can we avoid hard code versions for these libraries? A
We need to use an old version instead of the latest one because what we are
doing here is to copy the version the repository (ideally the local one, but
will fetch from the remote if it is not there). If we try to fetch the version
we are compiling that will fail (because this is executed before our build of
the plugin is installed).
> Also, why is the version 0.10.0?
Any version is valid. Remember we only use this in a test to verify that
realms are working as expected (ie that X class is read from the plugin while Y
is read from pinot-framework).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
