gortiz commented on code in PR #13598:
URL: https://github.com/apache/pinot/pull/13598#discussion_r1741486387
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/pipeline/PipelineBreakerExecutor.java:
##########
@@ -68,7 +69,7 @@ private PipelineBreakerExecutor() {
@Nullable
public static PipelineBreakerResult
executePipelineBreakers(OpChainSchedulerService scheduler,
MailboxService mailboxService, WorkerMetadata workerMetadata, StagePlan
stagePlan,
- Map<String, String> opChainMetadata, long requestId, long deadlineMs) {
+ Map<String, String> opChainMetadata, long requestId, long deadlineMs,
ThreadExecutionContext parentContext) {
Review Comment:
parentContext should be nullable.
nit/suggestion: Can we have a executePipelineBreaker(OpChainSchedulerService
scheduler,
MailboxService mailboxService, WorkerMetadata workerMetadata,
StagePlan stagePlan,
Map<String, String> opChainMetadata, long requestId, long deadlineMs)
that just calls this method with null as last argument? That would reduce this
PR by a large margin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
