ankitsultana commented on PR #13885: URL: https://github.com/apache/pinot/pull/13885#issuecomment-2322522965
> Seems you are adding the ser/de layer in this PR. I don't think they belong to SPI This is temporary and I can add a TODO (or create an issue). Right now I am relying on Jackson for the serde and we unfortunately have some Serde related code in the plan nodes (JsonCreator, JsonProperty, etc.). Keeping the SPI here for now allows users to test their plans easily. I am thinking of building a better approach once the baseline implementation is ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
