Jackie-Jiang commented on code in PR #13758:
URL: https://github.com/apache/pinot/pull/13758#discussion_r1716305239
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/NullableSingleInputAggregationFunction.java:
##########
@@ -119,6 +122,12 @@ public <A> A foldNotNull(int length, BlockValSet
blockValSet, A initialAcum, Red
*/
public <A> A foldNotNull(int length, @Nullable RoaringBitmap roaringBitmap,
A initialAcum, Reducer<A> reducer) {
IntIterator intIterator = roaringBitmap == null ? null :
roaringBitmap.getIntIterator();
+
+ // Exit early if entire block is null
+ if (_nullHandlingEnabled && roaringBitmap != null &&
roaringBitmap.contains(0, length)) {
+ return initialAcum;
+ }
Review Comment:
(minor) We might want to move this before getting the iterator
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
