sajjad-moradi commented on code in PR #13717:
URL: https://github.com/apache/pinot/pull/13717#discussion_r1700649646
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/forward/FixedByteSVMutableForwardIndex.java:
##########
@@ -81,7 +81,10 @@ public FixedByteSVMutableForwardIndex(boolean
dictionaryEncoded, DataType stored
_valueSizeInBytes = storedType.size();
}
_numRowsPerChunk = numRowsPerChunk;
- _chunkSizeInBytes = numRowsPerChunk * _valueSizeInBytes;
+ _chunkSizeInBytes = (long) numRowsPerChunk * _valueSizeInBytes;
+ Preconditions.checkState(_chunkSizeInBytes < Integer.MAX_VALUE,
Review Comment:
That makes sense. Removed the precondition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
