shounakmk219 commented on code in PR #13544:
URL: https://github.com/apache/pinot/pull/13544#discussion_r1697944673
##########
pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManager.java:
##########
@@ -279,6 +376,17 @@ private void
addQueryQuotaCapacityUtilizationRateTableGaugeIfNeeded(String table
}
}
+ @Override
+ public boolean acquireDatabase(String databaseName) {
+ // Return true if query quota is disabled in the current broker.
+ if (isQueryRateLimitDisabled()) {
+ return true;
+ }
+ LOGGER.info("Trying to acquire token for database: {}", databaseName);
Review Comment:
Yes that's true. Will change the logic to skip the log when `queryQuota ==
null` so that its printed only for database queries that have quotas enabled on
the database.
Need to make similar updates for the table acquire part as well.
Will also lower its level to debug as `tryAcquireToken` prints the log when
acquire fails.
Thanks for pointing it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
