Jackie-Jiang commented on code in PR #13573:
URL: https://github.com/apache/pinot/pull/13573#discussion_r1673136740
##########
pinot-spi/src/main/java/org/apache/pinot/spi/annotations/ScalarFunction.java:
##########
@@ -54,14 +54,13 @@
/**
* Whether the scalar function expects and can handle null arguments.
- *
*/
boolean nullableParameters() default false;
- boolean isPlaceholder() default false;
-
/**
* Whether the scalar function takes various number of arguments.
*/
boolean isVarArg() default false;
+
+ @Deprecated boolean isPlaceholder() default false;
Review Comment:
Yes we do, thus keeping it here even though all usages are removed. The
special placeholder functions are moved to the `PinotOperatorTable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
