yashmayya commented on code in PR #13548:
URL: https://github.com/apache/pinot/pull/13548#discussion_r1668328277
##########
pom.xml:
##########
@@ -1069,6 +1069,24 @@
<version>${hadoop.version}</version>
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-client-runtime</artifactId>
+ <version>${hadoop.version}</version>
+ <scope>provided</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>commons-logging</groupId>
+ <artifactId>commons-logging</artifactId>
+ </exclusion>
+ </exclusions>
Review Comment:
This is an explicitly banned dependency here -
https://github.com/apache/pinot/blob/4b5bd217e4a70bc76f60d73897a0484f19955ed5/pom.xml#L1742-L1754
Without this exclusion, the enforcer plugin's enforce goal fails in the
build. We're excluding the `commons-logging` dependency from various other
dependencies due to this, for example -
https://github.com/apache/pinot/blob/4b5bd217e4a70bc76f60d73897a0484f19955ed5/pom.xml#L688-L698
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
