yashmayya commented on code in PR #13235:
URL: https://github.com/apache/pinot/pull/13235#discussion_r1615579138
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##########
@@ -237,6 +237,14 @@ private String getMultiStageQueryResponse(String query,
String queryOptions, Htt
String.format("Unable to dispatch multistage query for tables:
[%s]", tableNames))).toString();
}
instanceIds = findCommonBrokerInstances(brokerTenantsUnion);
+ if (instanceIds.isEmpty()) {
+ // No common broker found for table tenants
+ LOGGER.error("Unable to find a common broker instance for table
tenants. Tables: {}, Tenants: {}",
+ tableNames, brokerTenantsUnion);
+ return
QueryException.getException(QueryException.BROKER_RESOURCE_MISSING_ERROR,
Review Comment:
Ah, looks like `410` is for when no appropriate broker exists in the cluster
and `420` is for when the appropriate broker isn't online based on this -
https://github.com/apache/pinot/blob/518fd180981ffa614042b8a5236650a2af41bfe5/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java#L321-L328
So, I guess `410` / `BROKER_RESOURCE_MISSING_ERROR` is indeed the right one
to use here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
