jasperjiaguo commented on code in PR #12767:
URL: https://github.com/apache/pinot/pull/12767#discussion_r1594860919
##########
pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/MaxHitRateTracker.java:
##########
@@ -80,4 +82,14 @@ int getMaxCountPerBucket(long now) {
_lastAccessTimestamp = now;
return maxCount;
}
+
+ @VisibleForTesting
+ @Override
+ int getHitCount(long now) {
Review Comment:
Should this be `getHitCount()`? Otherwise
`finalQueryQuotaEntity.getMaxQpsTracker().getHitCount();` would be calling into
the base class impl? Am I missing smth here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
