tibrewalpratik17 opened a new pull request, #12964: URL: https://github.com/apache/pinot/pull/12964
label: `refactor` The PinotTaskManager had a lot of scheduleTask methods which was making it unreadable and hard to make changes as adding a new param needs to properly vetted throughout the code. This change leaves 4 public methods in the class: - Map<String, List<String>> scheduleTasksForDatabase(database, minionInstanceTag) - Map<String, List<String>> scheduleTasks(tableNamesWithType, isLeader, minionInstanceTag) - List<String> scheduleTaskForDatabase(taskType, database, minionInstanceTag) - List<String> scheduleTask(taskType, tables, minionInstanceTag) The first 2 methods schedules all the tasks for given table / database. The next 2 methods, schedules the task specified for database / tables. This makes the code more readable and easy to use. We can consider further consolidation by taking taskType as a param in the first 2 methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
