shounakmk219 commented on PR #12786: URL: https://github.com/apache/pinot/pull/12786#issuecomment-2063635664
Hey @tibrewalpratik17 the changes that went into this PR may create unexpected damage as the behaviour for the method `PinotTaskManager#scheduleTask(String, String)` has been changed from `scheduleTask(taskType, tableNameWithType)` to `scheduleTask(taskType, minionInstanceTag)`. This may break the systems that consume this method, for instance https://github.com/apache/pinot/blob/master/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/CronJobScheduleJob.java#L68 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
