xiangfu0 commented on code in PR #12712:
URL: https://github.com/apache/pinot/pull/12712#discussion_r1570060313


##########
.github/workflows/scripts/pr-tests/.pinot_tests_unit.sh:
##########
@@ -33,6 +33,7 @@ if [ "$RUN_TEST_SET" == "1" ]; then
       -pl 'pinot-spi' \
       -pl 'pinot-segment-spi' \
       -pl 'pinot-common' \
+      -pl ':pinot-yammer' \

Review Comment:
   It's a bit complicated as we need to put all the submodules of 
`pinot-metrics` into .
   Also this `pinot-yammer` is a very small test, so it's ok to run it double 
times.



##########
.github/workflows/scripts/pr-tests/.pinot_tests_unit.sh:
##########
@@ -33,6 +33,7 @@ if [ "$RUN_TEST_SET" == "1" ]; then
       -pl 'pinot-spi' \
       -pl 'pinot-segment-spi' \
       -pl 'pinot-common' \
+      -pl ':pinot-yammer' \

Review Comment:
   It's a bit complicated as we need to put all the submodules of 
`pinot-metrics` into the command.
   Also this `pinot-yammer` is a very small test, so it's ok to run it double 
times.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to