npawar commented on PR #12930: URL: https://github.com/apache/pinot/pull/12930#issuecomment-2059500312
This doesn't seem to be the right fix.. If you look at line https://github.com/apache/pinot/pull/12930/files#diff-f99e2a5e74a22eaa5a052fce00e6b265418fb6b419969de16976bb405ec11a65R649, the throttling is actually not enabled until that point. So this should have already been working as expected. If the issue reporter is seeing that it's not working, we need to instead investgate why the `enableThrottling` isn't working as expected. Perhaps add some logs and try to observe during startup, when the throttling actually kicks in, and confirm if this is an issue or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
