Jackie-Jiang commented on code in PR #12451:
URL: https://github.com/apache/pinot/pull/12451#discussion_r1505162788
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java:
##########
@@ -359,6 +357,12 @@ public boolean isPartialUpsertEnabled() {
&& _tableUpsertMetadataManager.getUpsertMode() ==
UpsertConfig.Mode.PARTIAL;
}
+ private boolean isUpsertPreloadEnabled() {
+ UpsertConfig upsertConfig = _tableConfig.getUpsertConfig();
+ return _tableUpsertMetadataManager != null && _segmentPreloadExecutor !=
null && upsertConfig != null
Review Comment:
Not introduced in this PR, but do we have checks in other places? Basically
we don't want it to skip preloading silently
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartitionUpsertMetadataManager.java:
##########
@@ -64,6 +68,14 @@ public interface PartitionUpsertMetadataManager extends
Closeable {
*/
void addSegment(ImmutableSegment segment);
+ /**
+ * Preload segments for the table partition. Segments can be added
differently during preloading.
+ */
+ void preloadSegments(TableDataManager tableDataManager, IndexLoadingConfig
indexLoadingConfig,
Review Comment:
Suggest only passing in `indexLoadingConfig`. Other properties can be set
during initialization. We can consider only setting `tableDataManager` during
initialization, and add getters in `TableDataManager` to get `helixManager` and
`segmentPreloadExecutor`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
