Jackie-Jiang commented on code in PR #12500:
URL: https://github.com/apache/pinot/pull/12500#discussion_r1503427564
##########
pinot-tools/src/test/java/org/apache/pinot/tools/streams/PinotRealtimeSourceTest.java:
##########
@@ -49,6 +49,28 @@ public void testBuilder() {
Assert.assertEquals(realtimeSource._rateLimiter, limiter);
}
+ @Test
+ public void testDefaultGuavaRateLimiter() throws Exception {
Review Comment:
Seems this does not follow `Pinot Style`
##########
pinot-tools/src/test/java/org/apache/pinot/tools/streams/PinotRealtimeSourceTest.java:
##########
@@ -49,6 +49,28 @@ public void testBuilder() {
Assert.assertEquals(realtimeSource._rateLimiter, limiter);
}
+ @Test
+ public void testDefaultGuavaRateLimiter() throws Exception {
Review Comment:
I don't really see how this test works (almost everything is mocked). I
guess we don't really need a test because the fix is self-explainable, and this
test is not really guarding the fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
