gortiz commented on PR #12403: URL: https://github.com/apache/pinot/pull/12403#issuecomment-1956502139
I'm still not sure how/what to create a test here. Some metrics take a while to appear (as explained in https://github.com/apache/pinot/issues/12344, we need to wait some minutes to see some metrics). Some other will never appear until we actually do something with the table (like upload them somewhere). What the suggested test will be checking is: * Whether the lifetime endpoints are being called * Whether deletion methods in metrics registry are working Both things are out of the scope of this PR and it isn't clear to me how to write these tests. Unless you think this is a blocker, I would prefer to merge it as it is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
