This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 21346f6001 Ensure FieldConfig.getEncodingType() is never null (#12430)
21346f6001 is described below
commit 21346f60012b48d38fd675b3ad108b5ffb5d1ff2
Author: Gonzalo Ortiz Jaureguizar <[email protected]>
AuthorDate: Fri Feb 16 21:00:52 2024 +0100
Ensure FieldConfig.getEncodingType() is never null (#12430)
---
.../java/org/apache/pinot/common/utils/config/TableConfigSerDeTest.java | 2 +-
.../src/main/java/org/apache/pinot/spi/config/table/FieldConfig.java | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
a/pinot-common/src/test/java/org/apache/pinot/common/utils/config/TableConfigSerDeTest.java
b/pinot-common/src/test/java/org/apache/pinot/common/utils/config/TableConfigSerDeTest.java
index 74f857a102..dc9235d793 100644
---
a/pinot-common/src/test/java/org/apache/pinot/common/utils/config/TableConfigSerDeTest.java
+++
b/pinot-common/src/test/java/org/apache/pinot/common/utils/config/TableConfigSerDeTest.java
@@ -536,7 +536,7 @@ public class TableConfigSerDeTest {
FieldConfig secondFieldConfig = fieldConfigList.get(1);
assertEquals(secondFieldConfig.getName(), "column2");
- assertNull(secondFieldConfig.getEncodingType());
+ assertEquals(secondFieldConfig.getEncodingType(),
FieldConfig.EncodingType.DICTIONARY);
assertNull(secondFieldConfig.getIndexType());
assertEquals(secondFieldConfig.getIndexTypes().size(), 0);
assertNull(secondFieldConfig.getProperties());
diff --git
a/pinot-spi/src/main/java/org/apache/pinot/spi/config/table/FieldConfig.java
b/pinot-spi/src/main/java/org/apache/pinot/spi/config/table/FieldConfig.java
index e1b554e54a..16b50ecbde 100644
--- a/pinot-spi/src/main/java/org/apache/pinot/spi/config/table/FieldConfig.java
+++ b/pinot-spi/src/main/java/org/apache/pinot/spi/config/table/FieldConfig.java
@@ -101,7 +101,7 @@ public class FieldConfig extends BaseJsonConfig {
@JsonProperty(value = "tierOverwrites") @Nullable JsonNode
tierOverwrites) {
Preconditions.checkArgument(name != null, "'name' must be configured");
_name = name;
- _encodingType = encodingType;
+ _encodingType = encodingType == null ? EncodingType.DICTIONARY :
encodingType;
_indexTypes = indexTypes != null ? indexTypes : (
indexType == null ? Lists.newArrayList() :
Lists.newArrayList(indexType));
_compressionCodec = compressionCodec;
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
