ankitsultana commented on code in PR #12392:
URL: https://github.com/apache/pinot/pull/12392#discussion_r1487202421
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java:
##########
@@ -570,6 +572,81 @@ public static String[] split(String input, String
delimiter, int limit) {
return StringUtils.splitByWholeSeparator(input, delimiter, limit);
}
+ /**
+ * @param input an input string for prefix strings generations.
+ * @param length the max length of the prefix strings for the string.
+ * @param regexChar the character for regex matching to be added to prefix
strings generated. e.g. '^'
+ * @return generate an array of prefix strings of the string that are
shorter than the specified length.
+ */
+ @ScalarFunction
+ public static String[] prefix(String input, int length, String regexChar) {
+ ObjectSet<String> prefixSet = new ObjectLinkedOpenHashSet<>();
Review Comment:
Missed this in the first pass. Can we return a list instead since that seems
more fitting for `prefixes`?
For the set version we could create `uniquePrefixes, uniqueSuffixes` or
something. Moreover we should specify how the set will be ordered since
otherwise the replicas of consuming segments will diverge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
