shounakmk219 commented on code in PR #12402:
URL: https://github.com/apache/pinot/pull/12402#discussion_r1487112838
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -91,8 +91,6 @@ public static class Helix {
public static final String ENABLE_CASE_INSENSITIVE_KEY =
"enable.case.insensitive";
public static final boolean DEFAULT_ENABLE_CASE_INSENSITIVE = true;
- public static final String ALLOW_TABLE_NAME_WITH_DATABASE =
"allow.table.name.with.database";
- public static final boolean DEFAULT_ALLOW_TABLE_NAME_WITH_DATABASE = false;
Review Comment:
Yeah even I thought about that but as part of introducing database we will
have lot of things like APIs, access control that's database aware so toggling
the behaviour everywhere based on the feature flag will be complicated.
Do you have a strong use-case in mind which needs banning dot in table name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
