zhtaoxiang opened a new pull request, #12404: URL: https://github.com/apache/pinot/pull/12404
`performance` Instead of creating a new SslContext for the same TlsConfig multiple times, this PR reuses the same SslContext if it's already created. 1. This saves memory by a. reducing the number of objects created. b. only one thread (https://github.com/apache/pinot/blob/master/pinot-common/src/main/java/org/apache/pinot/common/utils/TlsUtils.java#L385) will be created for reloading the same tls store and trust store when tlsconfigs are the same. 2. This can also speed up execution because SslContext only needs to be created ones for the same TlsConfig Reusing the same SslContext does not change the validation logic and does not introduce security flaws because the same key and ca are used in the old and new implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
