ankitsultana commented on code in PR #12336:
URL: https://github.com/apache/pinot/pull/12336#discussion_r1486707499
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/SegmentStatusChecker.java:
##########
@@ -323,9 +330,12 @@ private void updateSegmentMetrics(String
tableNameWithType, TableConfig tableCon
if (nOffline > 0) {
LOGGER.warn("Table {} has {} segments with no online replicas",
tableNameWithType, nOffline);
}
+ if (nLessReplicas > 0) {
+ LOGGER.info("Table {} has {} segments with no high availability",
tableNameWithType, nLessReplicas);
+ }
if (nReplicasExternal < nReplicasIdealMax) {
- LOGGER.warn("Table {} has {} replicas, below replication threshold :{}",
tableNameWithType, nReplicasExternal,
- nReplicasIdealMax);
+ LOGGER.warn("Table {} has {} replicas, below replication threshold :{},
with {} segments running with less than"
Review Comment:
What do we mean by "Table foo has x replicas"? Can we say: "Table foo has at
least one segment with x replicas...."
Also, you don't need to log `nLessReplicas` here since you are logging it
above anyways?
I think we should also rename `nReplicasExternal` to
`minReplicasOfAnySegment` to make this more readable.
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/SegmentStatusChecker.java:
##########
@@ -323,9 +330,12 @@ private void updateSegmentMetrics(String
tableNameWithType, TableConfig tableCon
if (nOffline > 0) {
LOGGER.warn("Table {} has {} segments with no online replicas",
tableNameWithType, nOffline);
}
+ if (nLessReplicas > 0) {
+ LOGGER.info("Table {} has {} segments with no high availability",
tableNameWithType, nLessReplicas);
Review Comment:
Let's reword this to be explicit. "with number of replicas less than the
replication factor"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
