tibrewalpratik17 commented on code in PR #12383:
URL: https://github.com/apache/pinot/pull/12383#discussion_r1483644800
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -660,8 +666,9 @@ protected void doTakeSnapshot() {
_serverMetrics.setValueOfPartitionGauge(_tableNameWithType, _partitionId,
ServerGauge.UPSERT_PRIMARY_KEYS_IN_SNAPSHOT_COUNT,
numPrimaryKeysInSnapshot);
_logger.info(
- "Finished taking snapshot for {} immutable segments with {} primary
keys (out of {} total segments) in {}ms",
- numImmutableSegments, numPrimaryKeysInSnapshot, numTrackedSegments,
System.currentTimeMillis() - startTimeMs);
+ "Finished taking snapshot for {} immutable segments with {} primary
keys (out of {} total segments, "
+ + "{} consuming segments) in {} ms", numImmutableSegments,
numPrimaryKeysInSnapshot, numTrackedSegments,
+ numConsumingSegments, System.currentTimeMillis() - startTimeMs);
Review Comment:
Right now, it's confusing to differentiate if the segment for which the
snapshot didn't come is the consuming one or there was an actual error. This
helps us differentiate. The message currently is:
```
Finished taking snapshot for 120 immutable segments with 7794903 primary
keys (out of 121 total segments) in 2343ms
```
Here the 1 segment missed is usually consuming segment. Either we can add
consuming segment info or subtract numConsumingSegment from total segments.
Anything works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
