tibrewalpratik17 commented on code in PR #12320:
URL: https://github.com/apache/pinot/pull/12320#discussion_r1469350003
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/realtimetoofflinesegments/RealtimeToOfflineSegmentsTaskGenerator.java:
##########
@@ -179,6 +179,10 @@ public List<PinotTaskConfig>
generateTasks(List<TableConfig> tableConfigs) {
skipGenerate = true;
break;
}
+ if (StringUtils.isBlank(segmentZKMetadata.getDownloadUrl())) {
Review Comment:
Umm should we throw a RuntimeException from here then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
