jackjlli commented on code in PR #12297:
URL: https://github.com/apache/pinot/pull/12297#discussion_r1462699835
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##########
@@ -223,8 +224,12 @@ protected void releaseAndRemoveAllSegments() {
segmentDataManagers = new ArrayList<>(_segmentDataManagerMap.values());
_segmentDataManagerMap.clear();
}
- for (SegmentDataManager segmentDataManager : segmentDataManagers) {
- releaseSegment(segmentDataManager);
+ if (!segmentDataManagers.isEmpty()) {
+ ExecutorService stopExecutorService =
Executors.newFixedThreadPool(segmentDataManagers.size());
+ for (SegmentDataManager segmentDataManager : segmentDataManagers) {
+ stopExecutorService.submit(() -> releaseSegment(segmentDataManager));
+ }
+ stopExecutorService.shutdown();
Review Comment:
Good point! Added the code below to wait for at most 10 minutes before
exiting the method.
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##########
@@ -223,8 +224,12 @@ protected void releaseAndRemoveAllSegments() {
segmentDataManagers = new ArrayList<>(_segmentDataManagerMap.values());
_segmentDataManagerMap.clear();
}
- for (SegmentDataManager segmentDataManager : segmentDataManagers) {
- releaseSegment(segmentDataManager);
+ if (!segmentDataManagers.isEmpty()) {
+ ExecutorService stopExecutorService =
Executors.newFixedThreadPool(segmentDataManagers.size());
+ for (SegmentDataManager segmentDataManager : segmentDataManagers) {
+ stopExecutorService.submit(() -> releaseSegment(segmentDataManager));
+ }
+ stopExecutorService.shutdown();
Review Comment:
Good point! Added the code below to wait at most 10 minutes before exiting
the method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
