gortiz commented on code in PR #11575:
URL: https://github.com/apache/pinot/pull/11575#discussion_r1342448892
##########
pinot-core/src/test/java/org/apache/pinot/core/transport/QueryRoutingTest.java:
##########
@@ -77,9 +78,16 @@ public void setUp() {
_requestCount = 0;
}
+ @AfterMethod
Review Comment:
I think this is the correct behavior. We need to deregister in order to add
a new mock. We could reset the mock, but that would make it even more "mock
dependent".
We could register the mock on a `@BeforeClass`, then clean it in a
`@BeforeMethod`. That would be fine, but I would need to modify the test even
more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
