gortiz commented on code in PR #11710:
URL: https://github.com/apache/pinot/pull/11710#discussion_r1340953692
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java:
##########
@@ -602,6 +602,16 @@ public void testTimeFunc(boolean useMultiStageQueryEngine)
assertEquals(oneHourAgoTodayStr, expectedOneHourAgoTodayStr);
}
+ @Test
+ public void testMaxSerializedResponseLengthPerServer()
+ throws Exception {
+ String queryWithOption = "SET maxSerializedResponseLengthPerServer=1000; "
+ SELECT_STAR_QUERY;
+ JsonNode response = postQuery(queryWithOption);
+ assert response.get("exceptions").size() > 0;
+ String exceptionStr =
response.get("exceptions").get(0).get("message").toString();
+ assert exceptionStr.contains("Serialized response exceeds threshold");
Review Comment:
I don't think it is a good idea to assert on messages. We should instead
create a specific QueryException with its own error code and assert that the
exception error code is that one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
