Jackie-Jiang commented on code in PR #11698:
URL: https://github.com/apache/pinot/pull/11698#discussion_r1339404257
##########
pinot-plugins/pinot-input-format/pinot-avro-base/src/main/java/org/apache/pinot/plugin/inputformat/avro/AvroRecordExtractor.java:
##########
@@ -74,7 +74,7 @@ public GenericRow extract(GenericRecord from, GenericRow to) {
}
} else {
for (String fieldName : _fields) {
- Object value = from.get(fieldName);
+ Object value = from.hasField(fieldName) ? from.get(fieldName) : null;
Review Comment:
This will introduce one extra map lookup per field. If we want to avoid
this, we can change the `T` to `GenericData.Record` and make a single lookup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
