walterddr commented on code in PR #11473:
URL: https://github.com/apache/pinot/pull/11473#discussion_r1329123287
##########
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java:
##########
@@ -146,6 +146,10 @@ public void init(PinotConfiguration brokerConf)
_brokerConf.getProperty(Helix.SET_INSTANCE_ID_TO_HOSTNAME_KEY,
false) ? NetUtils.getHostnameOrAddress()
: NetUtils.getHostAddress();
}
+ // Override multi-stage query runner hostname if not set explicitly
+ if
(!_brokerConf.containsKey(MultiStageQueryRunner.KEY_OF_QUERY_RUNNER_HOSTNAME)) {
+
_brokerConf.setProperty(MultiStageQueryRunner.KEY_OF_QUERY_RUNNER_HOSTNAME,
_hostname);
Review Comment:
should we deprecate this config if they are always available as the general
hostname? the only thing we need is the port in v2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
