siddharthteotia commented on code in PR #11558:
URL: https://github.com/apache/pinot/pull/11558#discussion_r1325026361
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/invertedindex/RealtimeLuceneDocIdCollector.java:
##########
@@ -60,9 +61,16 @@ public void setScorer(Scorable scorer)
@Override
public void collect(int doc)
throws IOException {
+ if (_shouldCancel) {
+ throw new RuntimeException("Lucene query was cancelled");
Review Comment:
Per my above comment in
https://github.com/apache/pinot/pull/11558#discussion_r1325017798, I am ok with
the terminology aspect of cancelled for Timeout.
However, please change the exception message to something more appropriate.
See the suggestion in
https://github.com/apache/pinot/pull/11558#discussion_r1325020854
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
