tibrewalpratik17 commented on code in PR #11437:
URL: https://github.com/apache/pinot/pull/11437#discussion_r1322755823
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -248,13 +252,15 @@ public BrokerResponse handleRequest(JsonNode request,
@Nullable SqlNodeAndOption
if (!hasAccess) {
_brokerMetrics.addMeteredGlobalValue(BrokerMeter.REQUEST_DROPPED_DUE_TO_ACCESS_ERROR,
1);
requestContext.setErrorCode(QueryException.ACCESS_DENIED_ERROR_CODE);
+ _brokerQueryEventListener.onQueryCompletion(new
BrokerQueryEventInfo(requestContext));
throw new WebApplicationException("Permission denied",
Response.Status.FORBIDDEN);
}
long requestId = _brokerIdGenerator.get();
requestContext.setRequestId(requestId);
JsonNode sql = request.get(Broker.Request.SQL);
if (sql == null) {
+ _brokerQueryEventListener.onQueryCompletion(new
BrokerQueryEventInfo(requestContext));
Review Comment:
Yes good point. I added it as `BROKER_REQUEST_SEND_ERROR_CODE` but let me
know if something else is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
