ankitsultana commented on code in PR #11561:
URL: https://github.com/apache/pinot/pull/11561#discussion_r1321849215
##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/PartitionGroupMetadataFetcher.java:
##########
@@ -63,8 +65,8 @@ public Exception getException() {
@Override
public Boolean call()
throws Exception {
- String clientId = PartitionGroupMetadataFetcher.class.getSimpleName() + "-"
- + _streamConfig.getTableNameWithType() + "-" + _topicName;
+ String clientId = PartitionGroupMetadataFetcher.class.getSimpleName() +
"-" + _topicName + "-try" + Integer
+ .toString(++_callRetries);
Review Comment:
> They are already existing code & all stream tech ( kafka , pulsar, kinesis
) have a topic name .
No I mean it doesn't make sense for the clientId to be incremented on
retries generally for all stream tech.
> This is a temporary solution . I did put up...
The point I am making is that this is not really needed and doesn't solve
the problem anyways. If there's a MBean already with name
"classname-mytopic-0", then all subsequent calls will still have the MBean
error logged because retry won't kick in anyways.
If your goal is to handle intermittent issues like DNS failures then the
MBean won't be registered either ways because the AppInfoParser call is the
last call and wouldn't be made (the DNS failure would throw before the code
reaches there)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
