xiangfu0 commented on code in PR #11472:
URL: https://github.com/apache/pinot/pull/11472#discussion_r1313204421
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/blocks/results/AggregationResultsBlock.java:
##########
@@ -45,10 +45,13 @@
public class AggregationResultsBlock extends BaseResultsBlock {
private final AggregationFunction[] _aggregationFunctions;
private final List<Object> _results;
+ private final QueryContext _queryContext;
- public AggregationResultsBlock(AggregationFunction[] aggregationFunctions,
List<Object> results) {
+ public AggregationResultsBlock(AggregationFunction[] aggregationFunctions,
List<Object> results,
+ QueryContext queryContext) {
_aggregationFunctions = aggregationFunctions;
_results = results;
+ _queryContext = queryContext;
Review Comment:
Does it make sense to put queryContext into BaseResultsBlock with a
constructor and use super here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
