gortiz commented on code in PR #11467:
URL: https://github.com/apache/pinot/pull/11467#discussion_r1311152875
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ComparisonFunctions.java:
##########
@@ -61,6 +61,6 @@ public static boolean equals(double a, double b) {
@ScalarFunction
public static boolean between(double val, double a, double b) {
- return val > a && val < b;
+ return val >= a && val <= b;
Review Comment:
Strange that we didn't have a test before. Could you add one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
