KKcorps commented on PR #11430: URL: https://github.com/apache/pinot/pull/11430#issuecomment-1693282516
> I don't follow the fix here. Even if a segment doesn't contain any valid doc ids, we should still generate empty snapshot file > > I think the reason why it could fail is that when the snapshot is taken (new consuming segment created), there is no guarantee the previous segment is already replaced with immutable segment. Basically `snapshotFileCount` could be 4 or 5 Interesting. Let me see if that can be handled as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
