Jackie-Jiang commented on code in PR #11369: URL: https://github.com/apache/pinot/pull/11369#discussion_r1299446355
########## pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-hadoop/pom.xml: ########## @@ -35,7 +35,7 @@ <url>https://pinot.apache.org/</url> <properties> <pinot.root>${basedir}/../../..</pinot.root> - <hadoop.version>2.10.1</hadoop.version> + <hadoop.version>3.2.4</hadoop.version> Review Comment: (minor) Should we just remove this override? ########## pinot-plugins/pinot-input-format/pinot-orc/pom.xml: ########## @@ -58,10 +68,20 @@ </exclusion> </exclusions> </dependency> + <dependency> + <groupId>org.apache.hadoop</groupId> + <artifactId>hadoop-hdfs-client</artifactId> + <scope>${hadoop.dependencies.scope}</scope> + </dependency> <dependency> <groupId>xml-apis</groupId> <artifactId>xml-apis</artifactId> <scope>compile</scope> </dependency> + <dependency> + <groupId>org.codehaus.woodstox</groupId> + <artifactId>stax2-api</artifactId> + <version>4.1</version> Review Comment: Should we add this into the root pom? ########## pinot-plugins/pinot-input-format/pinot-orc/pom.xml: ########## @@ -46,6 +46,16 @@ <groupId>org.apache.hadoop</groupId> <artifactId>hadoop-common</artifactId> <scope>${hadoop.dependencies.scope}</scope> + <exclusions> Review Comment: Should we add these exclusions into the root pom? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
